Opened 11 years ago

Closed 11 years ago

#90 closed defect (fixed)

Debian package vuurmuur-conf fails to build

Reported by: Matthijs Kooijman Owned by: Victor Julien
Priority: blocker Milestone: 0.8
Component: vuurmuur-conf Version:
Keywords: Cc:

Description

The current svn (r243) fails to build a Debian package, using both dpkg-buildpackage as well as debian/rules binary.

The problem with the last few commits is that the install target in scripts/Makefile.in does not honour $(DESTDIR), resulting in the script files being installed in the root filesystem.

Also, the directory to install in is not created, so install might fail when the script directory does not exist at installation time.

The attached patch fixes both of these issues. However, I'm not completely sure this is the right approach. The same Makefile.in also defines a install-vuurmuur_scriptDATA target, which seems to do exacty what the install target should do. Why is this not used, and what is it used for?

Attachments (1)

fix-makefile (750 bytes) - added by Matthijs Kooijman 11 years ago.
Patch against r243

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Matthijs Kooijman

Attachment: fix-makefile added

Patch against r243

comment:1 Changed 11 years ago by Victor Julien

Status: newassigned

The change was made to make sure the installed script were set to be executable, which vuurmuur_scriptDATA doesn't do. Obviously the 'fix' has it's own issues, thanks for the report.

Patches should be against Makefile.am as Makefile.in is autogenerated by 'automake'.

comment:2 Changed 11 years ago by Victor Julien

Milestone: undecided0.8
Priority: majorblocker

comment:3 Changed 11 years ago by Victor Julien

Resolution: fixed
Status: assignedclosed

Fixed by r245.

Note: See TracTickets for help on using tickets.