Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#116 closed enhancement (fixed)

add version to the about dialog of vuurmuur_conf

Reported by: rettub Owned by: Tiger!P
Priority: trivial Milestone: 0.8
Component: vuurmuur-conf Version: svn
Keywords: Cc:

Description

all said in the summary :)

Attachments (1)

version-in-about-dialog.patch (1.2 KB) - added by rettub 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by rettub

comment:1 Changed 8 years ago by Tiger!P

Owner: changed from Victor Julien to Tiger!P

comment:2 Changed 8 years ago by Tiger!P

Milestone: undecided0.9
Resolution: fixed
Status: newclosed

This has been put in the trunk with a small change. See r327 for the changes.

comment:3 in reply to:  2 Changed 8 years ago by rettub

Resolution: fixed
Status: closedreopened

Replying to tigerp:

This has been put in the trunk with a small change. See r327 for the changes.

looking at that patch again, may be a better solution is to use something like

'char about_version_string[sizeof(version_string) + strlen("Version:_\n") + 1];'

just to be aware of buffer overflow.

comment:4 Changed 8 years ago by rettub

Little late yesterday:) Not a buffer overflow is the problem (snprintf), a possible truncated string is.

comment:5 Changed 7 years ago by Victor Julien

Resolution: fixed
Status: reopenedclosed

comment:6 Changed 5 years ago by Victor Julien

Milestone: 0.90.8
Note: See TracTickets for help on using tickets.