Opened 4 years ago
Closed 4 years ago
#90 closed defect (fixed)
Debian package vuurmuur-conf fails to build
| Reported by: | matthijs | Owned by: | victor |
|---|---|---|---|
| Priority: | blocker | Milestone: | 0.8 |
| Component: | vuurmuur-conf | Version: | |
| Keywords: | Cc: |
Description
The current svn (r243) fails to build a Debian package, using both dpkg-buildpackage as well as debian/rules binary.
The problem with the last few commits is that the install target in scripts/Makefile.in does not honour $(DESTDIR), resulting in the script files being installed in the root filesystem.
Also, the directory to install in is not created, so install might fail when the script directory does not exist at installation time.
The attached patch fixes both of these issues. However, I'm not completely sure this is the right approach. The same Makefile.in also defines a install-vuurmuur_scriptDATA target, which seems to do exacty what the install target should do. Why is this not used, and what is it used for?
Attachments (1)
Change History (4)
Changed 4 years ago by matthijs
comment:1 Changed 4 years ago by victor
- Status changed from new to assigned
The change was made to make sure the installed script were set to be executable, which vuurmuur_scriptDATA doesn't do. Obviously the 'fix' has it's own issues, thanks for the report.
Patches should be against Makefile.am as Makefile.in is autogenerated by 'automake'.
comment:2 Changed 4 years ago by victor
- Milestone changed from undecided to 0.8
- Priority changed from major to blocker
comment:3 Changed 4 years ago by victor
- Resolution set to fixed
- Status changed from assigned to closed
Fixed by r245.
Patch against r243