Opened 4 years ago

Closed 4 years ago

Last modified 13 months ago

#116 closed enhancement (fixed)

add version to the about dialog of vuurmuur_conf

Reported by: rettub Owned by: tigerp
Priority: trivial Milestone: 0.8
Component: vuurmuur-conf Version: svn
Keywords: Cc:

Description

all said in the summary :)

Attachments (1)

version-in-about-dialog.patch (1.2 KB) - added by rettub 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by rettub

comment:1 Changed 4 years ago by tigerp

  • Owner changed from victor to tigerp

comment:2 follow-up: Changed 4 years ago by tigerp

  • Milestone changed from undecided to 0.9
  • Resolution set to fixed
  • Status changed from new to closed

This has been put in the trunk with a small change. See r327 for the changes.

comment:3 in reply to: ↑ 2 Changed 4 years ago by rettub

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to tigerp:

This has been put in the trunk with a small change. See r327 for the changes.

looking at that patch again, may be a better solution is to use something like

'char about_version_string[sizeof(version_string) + strlen("Version:_\n") + 1];'

just to be aware of buffer overflow.

comment:4 Changed 4 years ago by rettub

Little late yesterday:) Not a buffer overflow is the problem (snprintf), a possible truncated string is.

comment:5 Changed 4 years ago by victor

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:6 Changed 13 months ago by victor

  • Milestone changed from 0.9 to 0.8
Note: See TracTickets for help on using tickets.